Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: src/codegen.cc

Issue 27132: Experimental: disable fast case switches for now. See:... (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/toiger/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/codegen.cc
===================================================================
--- src/codegen.cc (revision 1361)
+++ src/codegen.cc (working copy)
@@ -471,6 +471,11 @@
bool CodeGenerator::TryGenerateFastCaseSwitchStatement(SwitchStatement* node) {
+ // TODO(238): Due to issue 238, fast case switches can crash on ARM
+ // and possibly IA32. They are disabled for now.
+ // See http://code.google.com/p/v8/issues/detail?id=238
+ return false;
+
ZoneList<CaseClause*>* cases = node->cases();
int length = cases->length();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698