Pass type arguments as a list in generic methods invocations

pkg/kernel/lib/transformations/closure/converter.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library kernel.transformations.closure.converter;
 
 import '../../ast.dart'
     show
         Arguments,
         Block,
@@ skipping 721 matching lines @@
 
     Arguments arguments = new Arguments(positional, types: types, named: named);
     InvocationExpression invocation = procedure.isInstanceMember
         ? new MethodInvocation(receiver, procedure.name, arguments, procedure)
         : new StaticInvocation(procedure, arguments);
     return new FunctionNode(new ReturnStatement(invocation),
         typeParameters: typeParameters,
         positionalParameters: positionalParameters,
         namedParameters: namedParameters,
         requiredParameterCount: function.requiredParameterCount,
-        returnType: substitute(function.returnType, substitution),
+        returnType: substitute(function.returnType, cloner.typeSubstitution),

[Dmitry Stefantsov, 2017/03/15 13:41:16]

This line fixes a bug in closure conversion. Previously, if a generic method was
torn off from a non-generic class instance, the new type information retrieved
from the method was lost and wasn't used to adjust the return type of the
method.

         inferredReturnValue: inferredReturnValue);
   }
 
   /// Creates copies of the type variables in [original] and returns a
   /// substitution that can be passed to [substitute] to substitute all uses of
   /// [original] with their copies.
   Map<TypeParameter, DartType> copyTypeVariables(
       Iterable<TypeParameter> original) {
     if (original.isEmpty) return const <TypeParameter, DartType>{};
     Map<TypeParameter, DartType> substitution = <TypeParameter, DartType>{};
@@ skipping 80 matching lines @@
   // TODO(ahe): Remove this method when we don't generate closure classes
   // anymore.
   void addClosureClassNote(Class closureClass) {
     closureClass.addMember(new Field(new Name("note"),
         type: coreTypes.stringClass.rawType,
         initializer: new StringLiteral(
             "This is temporary. The VM doesn't need closure classes."),
         fileUri: currentFileUri));
   }
 }