Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: tools/perf/benchmarks/system_health.py

Issue 2713093004: Enable the EQT metric for system health benchmarks. (Closed)
Patch Set: Fix TODO Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from benchmarks import page_cycler_v2 7 from benchmarks import page_cycler_v2
8 8
9 from core import perf_benchmark 9 from core import perf_benchmark
10 10
(...skipping 26 matching lines...) Expand all
37 options = timeline_based_measurement.Options( 37 options = timeline_based_measurement.Options(
38 chrome_trace_category_filter.ChromeTraceCategoryFilter()) 38 chrome_trace_category_filter.ChromeTraceCategoryFilter())
39 options.config.chrome_trace_config.category_filter.AddFilterString('rail') 39 options.config.chrome_trace_config.category_filter.AddFilterString('rail')
40 options.config.enable_battor_trace = True 40 options.config.enable_battor_trace = True
41 options.config.enable_chrome_trace = True 41 options.config.enable_chrome_trace = True
42 options.SetTimelineBasedMetrics([ 42 options.SetTimelineBasedMetrics([
43 'clockSyncLatencyMetric', 43 'clockSyncLatencyMetric',
44 'powerMetric', 44 'powerMetric',
45 'tracingMetric' 45 'tracingMetric'
46 ]) 46 ])
47 # TODO(ulan): Remove dependency on page_cycler_v2.
47 page_cycler_v2.AugmentOptionsForLoadingMetrics(options) 48 page_cycler_v2.AugmentOptionsForLoadingMetrics(options)
49 # The EQT metric depends on the same categories as the loading metric.
50 options.AddTimelineBasedMetric('expectedQueueingTimeMetric')
48 return options 51 return options
49 52
50 def CreateStorySet(self, options): 53 def CreateStorySet(self, options):
51 return page_sets.SystemHealthStorySet(platform=self.PLATFORM) 54 return page_sets.SystemHealthStorySet(platform=self.PLATFORM)
52 55
53 @classmethod 56 @classmethod
54 def ShouldTearDownStateAfterEachStoryRun(cls): 57 def ShouldTearDownStateAfterEachStoryRun(cls):
55 return True 58 return True
56 59
57 @classmethod 60 @classmethod
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 and load a blank page with multiprocess enabled. 179 and load a blank page with multiprocess enabled.
177 """ 180 """
178 181
179 def SetExtraBrowserOptions(self, options): 182 def SetExtraBrowserOptions(self, options):
180 options.AppendExtraBrowserArgs( 183 options.AppendExtraBrowserArgs(
181 ['--webview-sandboxed-renderer']) 184 ['--webview-sandboxed-renderer'])
182 185
183 @classmethod 186 @classmethod
184 def Name(cls): 187 def Name(cls):
185 return 'system_health.webview_startup_multiprocess' 188 return 'system_health.webview_startup_multiprocess'
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698