chrome/browser/extensions/service_worker_apitest.cc - Issue 2713083003: Use ContentSetting in chrome/ instead of PermissionStatus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/service_worker_apitest.cc

Issue 2713083003: Use ContentSetting in chrome/ instead of PermissionStatus (Closed)

Patch Set: really fix build? Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/service_worker_apitest.cc

diff --git a/chrome/browser/extensions/service_worker_apitest.cc b/chrome/browser/extensions/service_worker_apitest.cc

index 7615b12529c40d16c62fe1ebac29ef398dc99b8a..7f7c3ec59b9e2a4e66b4ce44c9af8815e68a2c86 100644

--- a/chrome/browser/extensions/service_worker_apitest.cc

+++ b/chrome/browser/extensions/service_worker_apitest.cc

@@ -223,7 +223,7 @@ class ServiceWorkerPushMessagingTest : public ServiceWorkerTest {

void GrantNotificationPermissionForTest(const GURL& url) {

GURL origin = url.GetOrigin();

DesktopNotificationProfileUtil::GrantPermission(profile(), origin);

- ASSERT_EQ(blink::mojom::PermissionStatus::GRANTED,

+ ASSERT_EQ(CONTENT_SETTING_ALLOW,

PermissionManager::Get(profile())->GetPermissionStatus(

CONTENT_SETTINGS_TYPE_NOTIFICATIONS, origin, origin));

}