chrome/browser/push_messaging/push_messaging_service_impl.h - Issue 2713083003: Use ContentSetting in chrome/ instead of PermissionStatus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_service_impl.h

Issue 2713083003: Use ContentSetting in chrome/ instead of PermissionStatus (Closed)

Patch Set: maybe fix android compile + address comments + basic tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/push_messaging/push_messaging_service_impl.h

diff --git a/chrome/browser/push_messaging/push_messaging_service_impl.h b/chrome/browser/push_messaging/push_messaging_service_impl.h

index 920f44e8180b6d20c1d5ff1835888729027a12ed..04dd34d517ba2450db8e80e5c662a0db909e13e0 100644

--- a/chrome/browser/push_messaging/push_messaging_service_impl.h

+++ b/chrome/browser/push_messaging/push_messaging_service_impl.h

@@ -146,7 +146,7 @@ class PushMessagingServiceImpl : public content::PushMessagingService,

void DoSubscribe(const PushMessagingAppIdentifier& app_identifier,

const content::PushSubscriptionOptions& options,

const RegisterCallback& callback,

- blink::mojom::PermissionStatus permission_status);

+ ContentSetting permission_status);

void SubscribeEnd(const RegisterCallback& callback,

const std::string& subscription_id,