chrome/browser/notifications/notification_permission_context_unittest.cc - Issue 2713083003: Use ContentSetting in chrome/ instead of PermissionStatus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_permission_context_unittest.cc

Issue 2713083003: Use ContentSetting in chrome/ instead of PermissionStatus (Closed)

Patch Set: maybe fix android compile + address comments + basic tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/message_center_settings_controller_unittest.cc ('k') | chrome/browser/notifications/notifier_state_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_permission_context_unittest.cc

diff --git a/chrome/browser/notifications/notification_permission_context_unittest.cc b/chrome/browser/notifications/notification_permission_context_unittest.cc

index 3c7f38b13cb500b5971687221c958f22bd1de28b..f61a25f8476319221df80d5a992fe3508db5e7b7 100644

--- a/chrome/browser/notifications/notification_permission_context_unittest.cc

+++ b/chrome/browser/notifications/notification_permission_context_unittest.cc

@@ -28,7 +28,6 @@

namespace {

void DoNothing(ContentSetting content_setting) {}

-void DoNothing2(blink::mojom::PermissionStatus content_setting) {}

class TestNotificationPermissionContext : public NotificationPermissionContext {

public:

@@ -298,7 +297,7 @@ TEST_F(NotificationPermissionContextTest, TestCancelledIncognitoRequest) {

// failing, PermissionManager::OnPermissionsRequestResponseStatus will crash.

int request_id = permission_manager->RequestPermission(

CONTENT_SETTINGS_TYPE_NOTIFICATIONS, web_contents()->GetMainFrame(),

- url.GetOrigin(), true /* user_gesture */, base::Bind(&DoNothing2));

+ url.GetOrigin(), true /* user_gesture */, base::Bind(&DoNothing));

permission_manager->CancelPermissionRequest(request_id);