chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h - Issue 2713083003: Use ContentSetting in chrome/ instead of PermissionStatus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h

Issue 2713083003: Use ContentSetting in chrome/ instead of PermissionStatus (Closed)

Patch Set: maybe fix android compile + address comments + basic tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/geolocation_permission_context_unittest.cc ('k') | chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h

diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h

index 800d3fe25ec442145bc238028f2a36392566c328..1f1d3e045b8eca0a731ecaabb96e83978b59d925 100644

--- a/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h

+++ b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h

@@ -7,6 +7,7 @@

#include "base/macros.h"

#include "chrome/common/features.h"

+#include "components/content_settings/core/common/content_settings.h"

#include "extensions/browser/guest_view/web_view/web_view_permission_helper.h"

#include "extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h"

#include "ppapi/features/features.h"

@@ -79,7 +80,7 @@ class ChromeWebViewPermissionHelperDelegate :

void OnGeolocationPermissionResponse(

int bridge_id,

bool user_gesture,

- const base::Callback<void(blink::mojom::PermissionStatus)>& callback,

+ const base::Callback<void(ContentSetting)>& callback,

bool allow,

const std::string& user_input);