Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2029)

Unified Diff: pkg/analysis_server/lib/src/analysis_server.dart

Issue 2713053002: Remove the --no-error-notification flag. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/doc/api.html ('k') | pkg/analysis_server/lib/src/server/driver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/analysis_server.dart
diff --git a/pkg/analysis_server/lib/src/analysis_server.dart b/pkg/analysis_server/lib/src/analysis_server.dart
index ab74c030b2d6bc0d050d023221953283f70e9fb5..0bfbe702a5eb7e1a662c87da5a5cc92dbb38226e 100644
--- a/pkg/analysis_server/lib/src/analysis_server.dart
+++ b/pkg/analysis_server/lib/src/analysis_server.dart
@@ -244,11 +244,6 @@ class AnalysisServer {
ServerPerformance _performance;
/**
- * The option possibly set from the server initialization which disables error notifications.
- */
- bool _noErrorNotification;
-
- /**
* The [Completer] that completes when analysis is complete.
*/
Completer _onAnalysisCompleteCompleter;
@@ -427,7 +422,6 @@ class AnalysisServer {
ServerContextManagerCallbacks contextManagerCallbacks =
new ServerContextManagerCallbacks(this, resourceProvider);
contextManager.callbacks = contextManagerCallbacks;
- _noErrorNotification = options.noErrorNotification;
AnalysisEngine.instance.logger = new AnalysisLogger(this);
_onAnalysisStartedController = new StreamController.broadcast();
_onFileAnalyzedController = new StreamController.broadcast();
@@ -1450,7 +1444,7 @@ class AnalysisServer {
* absolute path.
*/
bool shouldSendErrorsNotificationFor(String file) {
- return !_noErrorNotification && contextManager.isInAnalysisRoot(file);
+ return contextManager.isInAnalysisRoot(file);
}
void shutdown() {
@@ -1820,7 +1814,6 @@ class AnalysisServerOptions {
bool enableIncrementalResolutionValidation = false;
bool enableNewAnalysisDriver = false;
bool finerGrainedInvalidation = false;
- bool noErrorNotification = false;
bool noIndex = false;
bool useAnalysisHighlight2 = false;
String fileReadMode = 'as-is';
« no previous file with comments | « pkg/analysis_server/doc/api.html ('k') | pkg/analysis_server/lib/src/server/driver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698