Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: chrome/browser/resources/print_preview/data/ticket_items/copies.js

Issue 2713033003: Print Preview: Show error message if text is typed in Copies section (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/print_preview/settings/copies_settings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/print_preview/data/ticket_items/copies.js
diff --git a/chrome/browser/resources/print_preview/data/ticket_items/copies.js b/chrome/browser/resources/print_preview/data/ticket_items/copies.js
index 91e6acf475ddeafc719e53535df5c29632628fcb..2d5175094fe2546e2ffdee9c3e0502c912c94750 100644
--- a/chrome/browser/resources/print_preview/data/ticket_items/copies.js
+++ b/chrome/browser/resources/print_preview/data/ticket_items/copies.js
@@ -24,6 +24,9 @@ cr.define('print_preview.ticket_items', function() {
/** @override */
wouldValueBeValid: function(value) {
+ if (value == '') {
+ return false;
+ }
if (/[^\d]+/.test(value)) {
dpapad 2017/02/24 20:35:35 Nit (optional): Maybe combine the two conditions.
return false;
dpapad 2017/02/24 20:35:35 Suggestion for improvement, can be done separately
}
« no previous file with comments | « no previous file | chrome/browser/resources/print_preview/settings/copies_settings.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698