Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: chrome/browser/resources/print_preview/data/ticket_items/copies.js

Issue 2713033003: Print Preview: Show error message if text is typed in Copies section (Closed)
Patch Set: Use valueAsNumber instead of Number ToFixed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/print_preview/data/ticket_items/scaling.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('print_preview.ticket_items', function() { 5 cr.define('print_preview.ticket_items', function() {
6 'use strict'; 6 'use strict';
7 7
8 /** 8 /**
9 * Copies ticket item whose value is a {@code string} that indicates how many 9 * Copies ticket item whose value is a {@code string} that indicates how many
10 * copies of the document should be printed. The ticket item is backed by a 10 * copies of the document should be printed. The ticket item is backed by a
11 * string since the user can textually input the copies value. 11 * string since the user can textually input the copies value.
12 * @param {!print_preview.DestinationStore} destinationStore Destination store 12 * @param {!print_preview.DestinationStore} destinationStore Destination store
13 * used determine if a destination has the copies capability. 13 * used determine if a destination has the copies capability.
14 * @constructor 14 * @constructor
15 * @extends {print_preview.ticket_items.TicketItem} 15 * @extends {print_preview.ticket_items.TicketItem}
16 */ 16 */
17 function Copies(destinationStore) { 17 function Copies(destinationStore) {
18 print_preview.ticket_items.TicketItem.call( 18 print_preview.ticket_items.TicketItem.call(
19 this, null /*appState*/, null /*field*/, destinationStore); 19 this, null /*appState*/, null /*field*/, destinationStore);
20 }; 20 };
21 21
22 Copies.prototype = { 22 Copies.prototype = {
23 __proto__: print_preview.ticket_items.TicketItem.prototype, 23 __proto__: print_preview.ticket_items.TicketItem.prototype,
24 24
25 /** @override */ 25 /** @override */
26 wouldValueBeValid: function(value) { 26 wouldValueBeValid: function(value) {
27 if (/[^\d]+/.test(value)) { 27 return value != '';
28 return false;
29 }
30 var copies = parseInt(value, 10);
31 if (copies > 999 || copies < 1) {
32 return false;
33 }
34 return true;
35 }, 28 },
36 29
37 /** @override */ 30 /** @override */
38 isCapabilityAvailable: function() { 31 isCapabilityAvailable: function() {
39 return !!this.getCopiesCapability_(); 32 return !!this.getCopiesCapability_();
40 }, 33 },
41 34
42 /** @return {number} The number of copies indicated by the ticket item. */ 35 /** @return {number} The number of copies indicated by the ticket item. */
43 getValueAsNumber: function() { 36 getValueAsNumber: function() {
44 return parseInt(this.getValue(), 10); 37 var value = this.getValue();
38 return value == '' ? 0 : parseInt(value, 10);
45 }, 39 },
46 40
47 /** @override */ 41 /** @override */
48 getDefaultValueInternal: function() { 42 getDefaultValueInternal: function() {
49 var cap = this.getCopiesCapability_(); 43 var cap = this.getCopiesCapability_();
50 return cap.hasOwnProperty('default') ? cap.default : '1'; 44 return cap.hasOwnProperty('default') ? cap.default : '1';
51 }, 45 },
52 46
53 /** @override */ 47 /** @override */
54 getCapabilityNotAvailableValueInternal: function() { 48 getCapabilityNotAvailableValueInternal: function() {
(...skipping 12 matching lines...) Expand all
67 dest.capabilities.printer.copies) || 61 dest.capabilities.printer.copies) ||
68 null; 62 null;
69 } 63 }
70 }; 64 };
71 65
72 // Export 66 // Export
73 return { 67 return {
74 Copies: Copies 68 Copies: Copies
75 }; 69 };
76 }); 70 });
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/print_preview/data/ticket_items/scaling.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698