[inspector] added reconnect method for tests

src/inspector/v8-runtime-agent-impl.cc

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 718 matching lines @@
   return takeCoverage(m_inspector->isolate(), false, out_result);
 }
 
 void V8RuntimeAgentImpl::restore() {
   if (!m_state->booleanProperty(V8RuntimeAgentImplState::runtimeEnabled, false))
     return;
   m_frontend.executionContextsCleared();
   enable();
   if (m_state->booleanProperty(
           V8RuntimeAgentImplState::customObjectFormatterEnabled, false))
     m_session->setCustomObjectFormatterEnabled(true);

[dgozman, 2017/02/27 18:44:56]

Looks like we already restore it properly.

   if (m_state->booleanProperty(V8RuntimeAgentImplState::preciseCoverageStarted,
                                false))
     startPreciseCoverage();
 }
 
 Response V8RuntimeAgentImpl::enable() {
   if (m_enabled) return Response::OK();
   m_inspector->client()->beginEnsureAllContextsInGroup(
       m_session->contextGroupId());
   m_enabled = true;
   m_state->setBoolean(V8RuntimeAgentImplState::runtimeEnabled, true);
   m_inspector->enableStackCapturingIfNeeded();
   m_session->reportAllContexts(this);
+  m_session->setCustomObjectFormatterEnabled(m_state->booleanProperty(

[dgozman, 2017/02/27 18:44:56]

And we should not restore anything in enable. It just enables.

[kozy, 2017/02/27 19:57:13]

Ok, then we should forbid this method on disabled runtime agent - done.

+      V8RuntimeAgentImplState::customObjectFormatterEnabled, false));
+
   V8ConsoleMessageStorage* storage =
       m_inspector->ensureConsoleMessageStorage(m_session->contextGroupId());
   for (const auto& message : storage->messages()) {
     if (!reportMessage(message.get(), false)) break;
   }
   return Response::OK();
 }
 
 Response V8RuntimeAgentImpl::disable() {
   if (!m_enabled) return Response::OK();
   m_enabled = false;
   m_state->setBoolean(V8RuntimeAgentImplState::runtimeEnabled, false);
   m_inspector->disableStackCapturingIfNeeded();
   m_session->discardInjectedScripts();
+  m_session->setCustomObjectFormatterEnabled(false);
   reset();
   m_inspector->client()->endEnsureAllContextsInGroup(
       m_session->contextGroupId());
   stopPreciseCoverage();
   return Response::OK();
 }
 
 void V8RuntimeAgentImpl::reset() {
   m_compiledScripts.clear();
   if (m_enabled) {
@@ skipping 41 matching lines @@
 }
 
 bool V8RuntimeAgentImpl::reportMessage(V8ConsoleMessage* message,
                                        bool generatePreview) {
   message->reportToFrontend(&m_frontend, m_session, generatePreview);
   m_frontend.flush();
   return m_inspector->hasConsoleMessageStorage(m_session->contextGroupId());
 }
 
 }  // namespace v8_inspector