Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

Issue 2713013002: Track original URL when downloading a redirected page (Closed)
Patch Set: Update BUILD.gn to fix DEP check in analyze Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/net_error_tab_helper.cc ('k') | components/offline_pages/core/background/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
diff --git a/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc b/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
index 7d6a0b8513db0b857bb65ffac18e5d2b1623f719..3a1bee5a5e13b71f816948a4fca1163a23953015 100644
--- a/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
+++ b/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
@@ -167,6 +167,8 @@ void OfflineInternalsUIMessageHandler::HandleRequestQueueCallback(
save_page_request->SetDouble("lastAttempt",
request->last_attempt_time().ToJsTime());
save_page_request->SetString("id", std::to_string(request->request_id()));
+ save_page_request->SetString("originalUrl",
+ request->original_url().spec());
}
}
ResolveJavascriptCallback(base::StringValue(callback_id), save_page_requests);
@@ -282,13 +284,13 @@ void OfflineInternalsUIMessageHandler::HandleAddToRequestQueue(
std::ostringstream id_stream;
id_stream << base::GenerateGUID();
+ offline_pages::RequestCoordinator::SavePageLaterParams params;
+ params.url = GURL(url);
+ params.client_id = offline_pages::ClientId(offline_pages::kAsyncNamespace,
+ id_stream.str());
ResolveJavascriptCallback(
- *callback_id,
- base::FundamentalValue(request_coordinator_->SavePageLater(
- GURL(url), offline_pages::ClientId(
- offline_pages::kAsyncNamespace, id_stream.str()),
- true, offline_pages::RequestCoordinator::RequestAvailability::
- ENABLED_FOR_OFFLINER) > 0));
+ *callback_id, base::FundamentalValue(
+ request_coordinator_->SavePageLater(params) > 0));
} else {
ResolveJavascriptCallback(*callback_id, base::FundamentalValue(false));
}
« no previous file with comments | « chrome/browser/net/net_error_tab_helper.cc ('k') | components/offline_pages/core/background/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698