chrome/browser/android/offline_pages/offline_page_utils_unittest.cc - Issue 2713013002: Track original URL when downloading a redirected page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

Issue 2713013002: Track original URL when downloading a redirected page (Closed)

Patch Set: Update BUILD.gn to fix DEP check in analyze Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_utils.cc ('k') | chrome/browser/android/offline_pages/prerendering_offliner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

index 2be4550e402d9af775a3f030b7dfbe901f1e1e94..8f55101fdd8e6e87c10824208ee3c7e6061a3278 100644

--- a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

+++ b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

@@ -186,12 +186,11 @@ void OfflinePageUtilsTest::CreateRequests() {

RequestCoordinator* request_coordinator =

RequestCoordinatorFactory::GetForBrowserContext(profile());

- offline_pages::ClientId client_id;

- client_id.name_space = kDownloadNamespace;

- client_id.id = kTestPage3ClientId;

- request_coordinator->SavePageLater(

- kTestPage3Url, client_id, true,

- RequestCoordinator::RequestAvailability::ENABLED_FOR_OFFLINER);

+ RequestCoordinator::SavePageLaterParams params;

+ params.url = kTestPage3Url;

+ params.client_id =

+ offline_pages::ClientId(kDownloadNamespace, kTestPage3ClientId);

+ request_coordinator->SavePageLater(params);

RunUntilIdle();

}