chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc - Issue 2713013002: Track original URL when downloading a redirected page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

Issue 2713013002: Track original URL when downloading a redirected page (Closed)

Patch Set: Update BUILD.gn to fix DEP check in analyze Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc ('k') | chrome/browser/android/offline_pages/offline_page_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

diff --git a/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc b/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

index 81af5aed8b0b9351ef4a6fed0bc882489a40f693..db1d635c45bc1518ffb5aa19e55d14b726e71729 100644

--- a/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

+++ b/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

@@ -349,10 +349,11 @@ void OfflinePageEvaluationBridge::SavePageLater(

client_id.name_space = ConvertJavaStringToUTF8(env, j_namespace);

client_id.id = ConvertJavaStringToUTF8(env, j_client_id);

- request_coordinator_->SavePageLater(

- GURL(ConvertJavaStringToUTF8(env, j_url)), client_id,

- static_cast<bool>(user_requested),

- RequestCoordinator::RequestAvailability::ENABLED_FOR_OFFLINER);

+ RequestCoordinator::SavePageLaterParams params;

+ params.url = GURL(ConvertJavaStringToUTF8(env, j_url));

+ params.client_id = client_id;

+ params.user_requested = static_cast<bool>(user_requested);

+ request_coordinator_->SavePageLater(params);

}

void OfflinePageEvaluationBridge::GetRequestsInQueue(