Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: components/offline_pages/core/background/request_queue_store_unittest.cc

Issue 2713013002: Track original URL when downloading a redirected page (Closed)
Patch Set: A little update Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/background/request_queue_store_unittest.cc
diff --git a/components/offline_pages/core/background/request_queue_store_unittest.cc b/components/offline_pages/core/background/request_queue_store_unittest.cc
index 7d697c6e32849100e68d212b26a422a1d46e7f1a..56b6564408259af50d3076609129dbb7bfc4cd6d 100644
--- a/components/offline_pages/core/background/request_queue_store_unittest.cc
+++ b/components/offline_pages/core/background/request_queue_store_unittest.cc
@@ -283,6 +283,7 @@ TYPED_TEST(RequestQueueStoreTest, AddRequest) {
base::Time creation_time = base::Time::Now();
SavePageRequest request(kRequestId, kUrl, kClientId, creation_time,
kUserRequested);
+ request.set_original_url(kUrl2);
fgorski 2017/02/27 17:34:36 please add upgrade test as well. E.g. https://cs.c
jianli 2017/02/27 23:20:07 Done.
store->AddRequest(request,
base::Bind(&RequestQueueStoreTestBase::AddRequestDone,
@@ -340,6 +341,7 @@ TYPED_TEST(RequestQueueStoreTest, UpdateRequest) {
SavePageRequest updated_request(kRequestId, kUrl, kClientId,
new_creation_time, activation_time,
kUserRequested);
+ updated_request.set_original_url(kUrl2);
// Try to update a non-existing request.
SavePageRequest updated_request2(kRequestId2, kUrl, kClientId,
new_creation_time, activation_time,

Powered by Google App Engine
This is Rietveld 408576698