Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: chrome/browser/android/offline_pages/prerendering_offliner.cc

Issue 2713013002: Track original URL when downloading a redirected page (Closed)
Patch Set: A little update Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/prerendering_offliner.h" 5 #include "chrome/browser/android/offline_pages/prerendering_offliner.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/metrics/histogram_macros.h" 8 #include "base/metrics/histogram_macros.h"
9 #include "base/sys_info.h" 9 #include "base/sys_info.h"
10 #include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h" 10 #include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 std::unique_ptr<OfflinePageArchiver> archiver( 60 std::unique_ptr<OfflinePageArchiver> archiver(
61 new OfflinePageMHTMLArchiver(web_contents)); 61 new OfflinePageMHTMLArchiver(web_contents));
62 62
63 OfflinePageModel::SavePageParams save_page_params; 63 OfflinePageModel::SavePageParams save_page_params;
64 save_page_params.url = web_contents->GetLastCommittedURL(); 64 save_page_params.url = web_contents->GetLastCommittedURL();
65 save_page_params.client_id = request.client_id(); 65 save_page_params.client_id = request.client_id();
66 save_page_params.proposed_offline_id = request.request_id(); 66 save_page_params.proposed_offline_id = request.request_id();
67 save_page_params.is_background = true; 67 save_page_params.is_background = true;
68 // Pass in the original URL if it is different from the last committed URL 68 // Pass in the original URL if it is different from the last committed URL
69 // when redirects occur. 69 // when redirects occur.
70 if (save_page_params.url != request.url()) 70 if (!request.original_url().is_empty())
71 save_page_params.original_url = request.original_url();
72 else if (save_page_params.url != request.url())
71 save_page_params.original_url = request.url(); 73 save_page_params.original_url = request.url();
72 74
73 SavePage(save_page_params, std::move(archiver), 75 SavePage(save_page_params, std::move(archiver),
74 base::Bind(&PrerenderingOffliner::OnSavePageDone, 76 base::Bind(&PrerenderingOffliner::OnSavePageDone,
75 weak_ptr_factory_.GetWeakPtr(), request)); 77 weak_ptr_factory_.GetWeakPtr(), request));
76 } else { 78 } else {
77 // Clear pending request and app listener then run completion callback. 79 // Clear pending request and app listener then run completion callback.
78 pending_request_.reset(nullptr); 80 pending_request_.reset(nullptr);
79 app_listener_.reset(nullptr); 81 app_listener_.reset(nullptr);
80 completion_callback_.Run(request, load_status); 82 completion_callback_.Run(request, load_status);
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 base::android::APPLICATION_STATE_HAS_RUNNING_ACTIVITIES) { 240 base::android::APPLICATION_STATE_HAS_RUNNING_ACTIVITIES) {
239 DVLOG(1) << "App became active, canceling current offlining request"; 241 DVLOG(1) << "App became active, canceling current offlining request";
240 SavePageRequest* request = pending_request_.get(); 242 SavePageRequest* request = pending_request_.get();
241 Cancel(); 243 Cancel();
242 completion_callback_.Run(*request, 244 completion_callback_.Run(*request,
243 Offliner::RequestStatus::FOREGROUND_CANCELED); 245 Offliner::RequestStatus::FOREGROUND_CANCELED);
244 } 246 }
245 } 247 }
246 248
247 } // namespace offline_pages 249 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698