Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

Issue 2713013002: Track original URL when downloading a redirected page (Closed)
Patch Set: A little update Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/evaluation/offline_page_evaluatio n_bridge.h" 5 #include "chrome/browser/android/offline_pages/evaluation/offline_page_evaluatio n_bridge.h"
6 6
7 #include "base/android/callback_android.h" 7 #include "base/android/callback_android.h"
8 #include "base/android/jni_android.h" 8 #include "base/android/jni_android.h"
9 #include "base/android/jni_array.h" 9 #include "base/android/jni_array.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 331 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 JNIEnv* env, 342 JNIEnv* env,
343 const JavaParamRef<jobject>& obj, 343 const JavaParamRef<jobject>& obj,
344 const JavaParamRef<jstring>& j_url, 344 const JavaParamRef<jstring>& j_url,
345 const JavaParamRef<jstring>& j_namespace, 345 const JavaParamRef<jstring>& j_namespace,
346 const JavaParamRef<jstring>& j_client_id, 346 const JavaParamRef<jstring>& j_client_id,
347 jboolean user_requested) { 347 jboolean user_requested) {
348 offline_pages::ClientId client_id; 348 offline_pages::ClientId client_id;
349 client_id.name_space = ConvertJavaStringToUTF8(env, j_namespace); 349 client_id.name_space = ConvertJavaStringToUTF8(env, j_namespace);
350 client_id.id = ConvertJavaStringToUTF8(env, j_client_id); 350 client_id.id = ConvertJavaStringToUTF8(env, j_client_id);
351 351
352 request_coordinator_->SavePageLater( 352 RequestCoordinator::SavePageLaterParams params;
353 GURL(ConvertJavaStringToUTF8(env, j_url)), client_id, 353 params.url = GURL(ConvertJavaStringToUTF8(env, j_url));
354 static_cast<bool>(user_requested), 354 params.client_id = client_id;
355 RequestCoordinator::RequestAvailability::ENABLED_FOR_OFFLINER); 355 params.user_requested = static_cast<bool>(user_requested);
fgorski 2017/02/27 17:34:35 are you missing availability here?
jianli 2017/02/27 23:20:06 By default, the availability is set to ENABLED_FOR
356 request_coordinator_->SavePageLater(params);
356 } 357 }
357 358
358 void OfflinePageEvaluationBridge::GetRequestsInQueue( 359 void OfflinePageEvaluationBridge::GetRequestsInQueue(
359 JNIEnv* env, 360 JNIEnv* env,
360 const JavaParamRef<jobject>& obj, 361 const JavaParamRef<jobject>& obj,
361 const JavaParamRef<jobject>& j_callback_obj) { 362 const JavaParamRef<jobject>& j_callback_obj) {
362 ScopedJavaGlobalRef<jobject> j_callback_ref(j_callback_obj); 363 ScopedJavaGlobalRef<jobject> j_callback_ref(j_callback_obj);
363 request_coordinator_->GetAllRequests( 364 request_coordinator_->GetAllRequests(
364 base::Bind(&OnGetAllRequestsDone, j_callback_ref)); 365 base::Bind(&OnGetAllRequestsDone, j_callback_ref));
365 } 366 }
(...skipping 15 matching lines...) Expand all
381 return; 382 return;
382 JNIEnv* env = base::android::AttachCurrentThread(); 383 JNIEnv* env = base::android::AttachCurrentThread();
383 ScopedJavaLocalRef<jobject> obj = weak_java_ref_.get(env); 384 ScopedJavaLocalRef<jobject> obj = weak_java_ref_.get(env);
384 if (obj.is_null()) 385 if (obj.is_null())
385 return; 386 return;
386 Java_OfflinePageEvaluationBridge_offlinePageModelLoaded(env, obj); 387 Java_OfflinePageEvaluationBridge_offlinePageModelLoaded(env, obj);
387 } 388 }
388 389
389 } // namespace android 390 } // namespace android
390 } // namespace offline_pages 391 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698