Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 27130002: Run google_apis_unittests on tryserver master. (Closed)

Created:
7 years, 2 months ago by tfarina
Modified:
6 years, 10 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, Mike Stip (use stip instead), Isaac (away)
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M masters/master.tryserver.chromium/master.cfg View 11 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
Based on https://chromiumcodereview.appspot.com/11946038 Isaac, could you do the review if Robert is unavailable?
7 years, 2 months ago (2013-10-13 17:04:31 UTC) #1
Jói
LGTM but please wait for someone who actually knows this stuff :)
7 years, 2 months ago (2013-10-14 08:23:20 UTC) #2
tfarina
Mike? Could you take a look at this? Thanks!
7 years, 2 months ago (2013-10-18 00:19:53 UTC) #3
ghost stip (do not use)
lgtm
7 years, 2 months ago (2013-10-18 01:58:22 UTC) #4
Mike Stip (use stip instead)
cq doesn't know about stip yet so lgtm
7 years, 2 months ago (2013-10-18 01:58:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/27130002/1
7 years, 2 months ago (2013-10-18 18:00:21 UTC) #6
commit-bot: I haz the power
Change committed as 229442
7 years, 2 months ago (2013-10-18 18:01:00 UTC) #7
earthdok
6 years, 10 months ago (2014-02-21 17:20:12 UTC) #8
Message was sent while issue was closed.
On 2013/10/18 18:01:00, I haz the power (commit-bot) wrote:
> Change committed as 229442

Please see https://codereview.chromium.org/107413007/#msg10

Powered by Google App Engine
This is Rietveld 408576698