Issue 27130: Experimental: fix a bug in our handling of the short-circuit boolean...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27130: Experimental: fix a bug in our handling of the short-circuit boolean... (Closed)

Created:
11 years, 10 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/toiger/

Visibility:
Public.

Description

Experimental: fix a bug in our handling of the short-circuit boolean operators && and ||. Correctly detect that the left subexpression of && is unconditionally false and set the state of the inherited control destination; and if it is not unconditionally false ensure that the right subexpression is compiled. Analogously for ||. Committed: http://code.google.com/p/v8/source/detail?r=1361

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -16 lines)			Patch
	M	src/codegen-ia32.h	View		1 chunk	+12 lines, -0 lines	0 comments	Download
	M	src/codegen-ia32.cc	View		4 chunks	+49 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM Please add regression tests for this.

11 years, 10 months ago (2009-02-25 13:14:40 UTC) #2

LGTM.

Expand Messages | Collapse Messages