cc/output/begin_frame_args.h - Issue 2712983003: [cc] Set BeginFrame sequence numbers on CompositorFrames from Scheduler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/begin_frame_args.h

Issue 2712983003: [cc] Set BeginFrame sequence numbers on CompositorFrames from Scheduler. (Closed)

Patch Set: store BeginFrameAck instead. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/output/begin_frame_args.h

diff --git a/cc/output/begin_frame_args.h b/cc/output/begin_frame_args.h

index 7fe704c572be0e822cbe4fa7b2ab2d2bd10a0853..48d3ee9472d33e9dc5fce20b442a2ca07c12a421 100644

--- a/cc/output/begin_frame_args.h

+++ b/cc/output/begin_frame_args.h

@@ -50,6 +50,9 @@ struct CC_EXPORT BeginFrameArgs {

};

static const char* TypeToString(BeginFrameArgsType type);

+ static constexpr uint32_t kStartingSourceId = 0;

+ static constexpr uint32_t kManualSourceId = UINT32_MAX;

brianderson 2017/03/02 19:53:36 Can you add a comment explaining what a manual sou

Eric Seckler 2017/03/07 12:26:56 Done.

static constexpr uint64_t kInvalidFrameNumber = 0;

static constexpr uint64_t kStartingFrameNumber = 1;