Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Unified Diff: cc/trees/single_thread_proxy.cc

Issue 2712983003: [cc] Set BeginFrame sequence numbers on CompositorFrames from Scheduler. (Closed)
Patch Set: sync Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/trees/layer_tree_host_unittest.cc ('K') | « cc/trees/proxy_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/single_thread_proxy.cc
diff --git a/cc/trees/single_thread_proxy.cc b/cc/trees/single_thread_proxy.cc
index 83853354649b20e8bb6e61f433606cc97a696759..c201a7b6574123bfde8571e54d99ab0873639b3a 100644
--- a/cc/trees/single_thread_proxy.cc
+++ b/cc/trees/single_thread_proxy.cc
@@ -447,7 +447,7 @@ void SingleThreadProxy::CompositeImmediately(base::TimeTicks frame_begin_time) {
}
BeginFrameArgs begin_frame_args(BeginFrameArgs::Create(
- BEGINFRAME_FROM_HERE, 0, 1, frame_begin_time, base::TimeTicks(),
+ BEGINFRAME_FROM_HERE, UINT32_MAX, 1, frame_begin_time, base::TimeTicks(),
brianderson 2017/02/24 01:08:38 Can you make this a BeginFrameArgs constant with a
Eric Seckler 2017/02/27 11:50:32 Done.
BeginFrameArgs::DefaultInterval(), BeginFrameArgs::NORMAL));
// Start the impl frame.
@@ -483,6 +483,10 @@ void SingleThreadProxy::CompositeImmediately(base::TimeTicks frame_begin_time) {
layer_tree_host_impl_->Animate();
LayerTreeHostImpl::FrameData frame;
+ frame.begin_frame_source_id = begin_frame_args.source_id;
+ frame.begin_frame_sequence_number = begin_frame_args.sequence_number;
+ frame.latest_confirmed_begin_frame_sequence_number =
+ begin_frame_args.sequence_number;
DoComposite(&frame);
// DoComposite could abort, but because this is a synchronous composite
@@ -689,6 +693,13 @@ void SingleThreadProxy::BeginMainFrameAbortedOnImplThread(
DrawResult SingleThreadProxy::ScheduledActionDrawIfPossible() {
DebugScopedSetImplThread impl(task_runner_provider_);
LayerTreeHostImpl::FrameData frame;
+ frame.begin_frame_source_id =
+ scheduler_on_impl_thread_->CurrentBeginFrameSourceId();
+ frame.begin_frame_sequence_number =
+ scheduler_on_impl_thread_->CurrentBeginFrameSequenceNumber();
+ frame.latest_confirmed_begin_frame_sequence_number =
+ scheduler_on_impl_thread_
+ ->LatestConfirmedBeginFrameSequenceNumberForActiveTree();
return DoComposite(&frame);
}
« cc/trees/layer_tree_host_unittest.cc ('K') | « cc/trees/proxy_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698