Issue 2712953002: Better comment for embedded names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2712953002: Better comment for embedded names. (Closed)

Created:
3 years, 10 months ago by floitsch

Modified:
3 years, 10 months ago

Reviewers:
ahe, sra1

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Better comment for embedded names. Committed: https://github.com/dart-lang/sdk/commit/6cf3c51414b2140a876131fad7d392545a880243

Patch Set 1 #

Total comments: 1

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 6 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

floitsch

Committed patchset #1 (id:1) manually as 6cf3c51414b2140a876131fad7d392545a880243 (presubmit successful).

3 years, 10 months ago (2017-02-23 12:52:32 UTC) #4

ahe

3 years, 10 months ago (2017-02-23 12:58:11 UTC) #6

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/2712953002/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart (right):

https://codereview.chromium.org/2712953002/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart:321: /// instances
of parametrized classes.
I think the common spelling is "parameterized".

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages