Cocoa Page Info: Implement expanding all permissions

Cocoa Page Info: Implement expanding all permissions

BUG=657267

[lgarron, 2017-02-24 01:53:24]

Description was changed from

==========
Cocoa Page Info: Implement explanding all permissions

BUG=657267
==========

to

==========
Cocoa Page Info: Implement expanding all permissions

BUG=657267
==========

[lgarron, 2017-02-24 01:53:42]

lgarron@chromium.org changed reviewers:
+ rsesek@chromium.org

[lgarron, 2017-02-24 01:53:43]

rsesek@, could you review?

See https://bugs.chromium.org/p/chromium/issues/detail?id=657267#c9 for a
screenvid.

[Robert Sesek, 2017-02-24 22:17:45]

Generally LG, but a few questions:

- The note I left on the bug about the animation.
- Did you test this in RTL?

[lgarron, 2017-02-28 03:50:51]

On 2017/02/24 at 22:17:45, rsesek wrote:
> Generally LG, but a few questions:
> 
> - The note I left on the bug about the animation.
> - Did you test this in RTL?

Yes, I've tested in RTL; this change doesn't touch any of the horizontal layout
calculations except the site settings button alignment, and everything still
lays out correctly in RTL after interactions.

One simple option to avoid the animation issue is to simply set `animate:NO` at
[1]. Given that nothing else will grow the window anymore, that seems reasonable
to me.
I don't know the right place to start addressing it otherwise.

[1]
https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/website_settings...

[Robert Sesek, 2017-03-01 16:29:04]

(I'm holding off on further review of this CL because it seems like the bug is
still actively discussing how this should look. Please ping me if you want me to
take another look).