Issue 271283003: Revert of Have apply_patch.py/checkout.py stage git patches instead of committing them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 271283003: Revert of Have apply_patch.py/checkout.py stage git patches instead of committing them (Closed)

Created:
6 years, 7 months ago by hinoka

Modified:
6 years, 7 months ago

Reviewers:
Ryan Tseng, agable, M-A Ruel, iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Revert of Have apply_patch.py/checkout.py stage git patches instead of committing them (https://codereview.chromium.org/273543002/) Reason for revert: Borked all the tryjobs due to missing --base_ref, needed to land with https://codereview.chromium.org/273543002/ Original issue's description: > Have apply_patch.py/checkout.py stage git patches instead of committing them > > For a bot_update Git world, we don't really want to commit patches. Instead > we just want to leave them unstaged. > > BUG=370503 > TEST=ran locally with and without flag > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=269468 TBR=maruel@chromium.org,agable@chromium.org,hinoka@google.com,iannucci@chromium.org NOTREECHECKS=true NOTRY=true BUG=370503 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=269482

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -16 lines)			Patch
M	apply_issue.py	View	3 chunks	+8 lines, -2 lines	0 comments	Download
M	checkout.py	View	8 chunks	+29 lines, -12 lines	0 comments	Download
M	tests/checkout_test.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

hinoka

Created Revert of Have apply_patch.py/checkout.py stage git patches instead of committing them

6 years, 7 months ago (2014-05-10 02:05:56 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@chromium.org/271283003/1

6 years, 7 months ago (2014-05-10 02:06:46 UTC) #2

Message was sent while issue was closed.

Change committed as 269482