Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issue 271283002: Disable Unified GR GestureRecognizerTest suit (Closed)

Created:
6 years, 7 months ago by tdresser
Modified:
6 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Visibility:
Public.

Description

Disable Unified GR GestureRecognizerTest suit This code path is disable by default, and is also tested in GestureProviderTest. The test suite is currently running into some memory leaks, see http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/32287/steps/memory%20test%3A%20aura/logs/stdio for an example. BUG=371990 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269647

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address sadrul's comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tdresser
6 years, 7 months ago (2014-05-09 20:37:07 UTC) #1
sadrul
https://codereview.chromium.org/271283002/diff/1/ui/aura/gestures/gesture_recognizer_unittest.cc File ui/aura/gestures/gesture_recognizer_unittest.cc (right): https://codereview.chromium.org/271283002/diff/1/ui/aura/gestures/gesture_recognizer_unittest.cc#newcode689 ui/aura/gestures/gesture_recognizer_unittest.cc:689: } Instead of running the tests twice with the ...
6 years, 7 months ago (2014-05-09 20:39:23 UTC) #2
sadrul
lgtm
6 years, 7 months ago (2014-05-09 20:46:10 UTC) #3
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 7 months ago (2014-05-09 20:46:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/271283002/20001
6 years, 7 months ago (2014-05-09 20:49:54 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 00:15:53 UTC) #6
Message was sent while issue was closed.
Change committed as 269647

Powered by Google App Engine
This is Rietveld 408576698