Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp

Issue 2712823003: Various logging-related cleanups & reformatting. (Closed)
Patch Set: Fix base unit-tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/test/gtest_util.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp
diff --git a/third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp b/third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp
index 3093f7c32196290e6b84fe9fca2c24002f0270d4..3a7a4ebcb066b9975a1cb93a9eaeb162f9d5ae43 100644
--- a/third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp
+++ b/third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp
@@ -15,6 +15,11 @@ TEST(AssertionsTest, Assertions) {
#if DCHECK_IS_ON()
EXPECT_DEATH_IF_SUPPORTED(DCHECK(false), "");
EXPECT_DEATH_IF_SUPPORTED(NOTREACHED(), "");
+ EXPECT_DEATH_IF_SUPPORTED(DCHECK_AT(false, __FILE__, __LINE__), "");
+#else
+ DCHECK(false);
+ NOTREACHED();
+ DCHECK_AT(false, __FILE__, __LINE__);
#endif
CHECK(true);
@@ -23,6 +28,8 @@ TEST(AssertionsTest, Assertions) {
SECURITY_DCHECK(true);
#if ENABLE(SECURITY_ASSERT)
EXPECT_DEATH_IF_SUPPORTED(SECURITY_DCHECK(false), "");
+#else
+ SECURITY_DCHECK(false);
#endif
SECURITY_CHECK(true);
« no previous file with comments | « base/test/gtest_util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698