Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: content/browser/android/string_message_codec.cc

Issue 2712783002: V8ScriptValueSerializer: Add a separate version 'envelope' for Blink format version. (Closed)
Patch Set: Merge branch 'master' into ssv-separate-version Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/string_message_codec.cc
diff --git a/content/browser/android/string_message_codec.cc b/content/browser/android/string_message_codec.cc
index aa258875ef539ec64df030c2bb84a4a9943c0865..b2bae5ddcf9ab311134d816bf9fc2d098e8e4b9f 100644
--- a/content/browser/android/string_message_codec.cc
+++ b/content/browser/android/string_message_codec.cc
@@ -114,19 +114,18 @@ bool DecodeStringMessage(const base::string16& encoded_data,
const uint8_t* ptr = reinterpret_cast<const uint8_t*>(&encoded_data[0]);
const uint8_t* end = ptr + num_bytes;
-
uint8_t tag;
- if (!ReadUint8(&ptr, end, &tag) || tag != kVersionTag)
- return false;
-
- uint32_t version;
- if (!ReadUint32(&ptr, end, &version))
- return false;
+ // Discard any leading version and padding tags.
+ // There may be more than one version, due to Blink and V8 having separate
+ // version tags.
do {
if (!ReadUint8(&ptr, end, &tag))
return false;
- } while (tag == kPaddingTag);
+ uint32_t version;
+ if (tag == kVersionTag && !ReadUint32(&ptr, end, &version))
+ return false;
+ } while (tag == kVersionTag || tag == kPaddingTag);
switch (tag) {
case kOneByteStringTag: {

Powered by Google App Engine
This is Rietveld 408576698