Add trace event for detecting main frame in loading metrics.

third_party/WebKit/public/web/WebLocalFrame.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WebLocalFrame_h
 #define WebLocalFrame_h
 
 #include <set>
 #include "WebCompositionUnderline.h"
 #include "WebFrame.h"
@@ skipping 484 matching lines @@
 
   // Returns frame-specific task runner to run tasks of this type on.
   // They have the same lifetime as the frame.
   virtual base::SingleThreadTaskRunner* timerTaskRunner() = 0;
   virtual base::SingleThreadTaskRunner* loadingTaskRunner() = 0;
   virtual base::SingleThreadTaskRunner* unthrottledTaskRunner() = 0;
 
   // Returns the WebInputMethodController associated with this local frame.
   virtual WebInputMethodController* inputMethodController() const = 0;
 
+  // Tracing support ----------------------------------------------------------
+  // Returns the value for the "frame" argument in TRACE_EVENT* calls.
+  // This function is intended to be used in components that do not have
+  // access to the local frame, but still want to trace frame related events.
+  virtual void* frameIdForTracing() const = 0;

[ulan, 2017/02/22 21:16:37]

This is not really nice. I would appreciate better suggestions.

The problem is that the existing TRACE_EVENTs use the address of the local frame
as the id (BTW, does it work if Oilpan does compaction?). 

The RenderFrameImpl doesn't seem to have access to the local frame, so we need
to either pull the frame id from Blink or push a bit to Blink saying whether the
frame is the main frame or not.

[haraken, 2017/02/22 23:56:21]

In practice, this will work because Oilpan's compaction moves only backing
stores of vectors, hashtables etc. Oilpan doesn't move normal objects like
Frame.

However, it's not nice to expose the frame ID via the public APIs.

+dcheng@ might have some ideas.

+
  protected:
   explicit WebLocalFrame(WebTreeScopeType scope) : WebFrame(scope) {}
 
   // Inherited from WebFrame, but intentionally hidden: it never makes sense
   // to call these on a WebLocalFrame.
   bool isWebLocalFrame() const override = 0;
   WebLocalFrame* toWebLocalFrame() override = 0;
   bool isWebRemoteFrame() const override = 0;
   WebRemoteFrame* toWebRemoteFrame() override = 0;
 };
 
 }  // namespace blink
 
 #endif  // WebLocalFrame_h