Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 2712743009: Adds tools/ninja.py that runs goma builds in parallel (Closed)

Created:
3 years, 10 months ago by zra
Modified:
3 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, bkonyi
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adds tools/ninja.py that runs goma builds in parallel This CL adds a script tools/ninja.py that runs Goma enabled builds in parallel. Non-goma builds are run serially, as before. Conflating this feature with gyp support in tools/build.py got to be a bit of a mess, which is why this is split off as a separate script. This script can replace build.py after gyp support is removed. With a warm goma: $ time ./tools/build.py -m debug,release -a x64,ia32 runtime runtime_precompiled ... real 4m25.627s user 3m30.740s sys 1m3.873s $ ./tools/ninja.py -m debug,release -a x64,ia32 runtime runtime_precompiled ... The build took 108.900 seconds R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/1f0168b95c7e2e8867cacb780a15e131f40ec65c

Patch Set 1 #

Patch Set 2 : Move new stuff to ninja.py #

Patch Set 3 : Add -j switch for Mac #

Total comments: 2

Patch Set 4 : Remove java configuration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -0 lines) Patch
A tools/ninja.py View 1 2 3 1 chunk +314 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zra
3 years, 9 months ago (2017-02-27 18:20:59 UTC) #3
rmacnak
LGTM! https://codereview.chromium.org/2712743009/diff/40001/tools/ninja.py File tools/ninja.py (right): https://codereview.chromium.org/2712743009/diff/40001/tools/ninja.py#newcode272 tools/ninja.py:272: utils.ConfigureJava() Probably leftover from the Java-based analyzer and ...
3 years, 9 months ago (2017-02-27 18:46:31 UTC) #4
zra
https://codereview.chromium.org/2712743009/diff/40001/tools/ninja.py File tools/ninja.py (right): https://codereview.chromium.org/2712743009/diff/40001/tools/ninja.py#newcode272 tools/ninja.py:272: utils.ConfigureJava() On 2017/02/27 18:46:31, rmacnak wrote: > Probably leftover ...
3 years, 9 months ago (2017-02-27 18:54:40 UTC) #5
zra
Committed patchset #4 (id:60001) manually as 1f0168b95c7e2e8867cacb780a15e131f40ec65c (presubmit successful).
3 years, 9 months ago (2017-02-27 18:55:09 UTC) #7
Florian Schneider
3 years, 9 months ago (2017-02-27 23:08:37 UTC) #8
Message was sent while issue was closed.
On 2017/02/27 18:55:09, zra wrote:
> Committed patchset #4 (id:60001) manually as
> 1f0168b95c7e2e8867cacb780a15e131f40ec65c (presubmit successful).

When I try to interrupt the build using ctrl-C, I can't and get the following
output:

KeyboardInterrupt
    racquire()
    racquire()
  File "/usr/lib/python2.7/multiprocessing/queues.py", line 374, in get
KeyboardInterrupt
KeyboardInterrupt
    racquire()
    racquire()
KeyboardInterrupt
KeyboardInterrupt
    racquire()
KeyboardInterrupt
    racquire()
  File "/usr/lib/python2.7/multiprocessing/pool.py", line 102, in worker
  File "/usr/lib/python2.7/multiprocessing/queues.py", line 374, in get
    task = get()
KeyboardInterrupt
  File "/usr/lib/python2.7/multiprocessing/queues.py", line 374, in get
  File "/usr/lib/python2.7/multiprocessing/queues.py", line 374, in get
KeyboardInterrupt
  File "/usr/lib/python2.7/multiprocessing/queues.py", line 374, in get
    racquire()
    racquire()
    task = get()
KeyboardInterrupt
  File "/usr/lib/python2.7/multiprocessing/queues.py", line 374, in get
    racquire()

Powered by Google App Engine
This is Rietveld 408576698