Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: content/browser/indexed_db/leveldb/leveldb_transaction.h

Issue 2712713005: Revert of IndexedDB: Optimize range deletion operations (e.g. clearing a store) (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/leveldb/leveldb_transaction.h
diff --git a/content/browser/indexed_db/leveldb/leveldb_transaction.h b/content/browser/indexed_db/leveldb/leveldb_transaction.h
index ef48628121cb158236f0ae1972ed6b253cedccf7..33392f235336abd55f607ec406250a6c66014113 100644
--- a/content/browser/indexed_db/leveldb/leveldb_transaction.h
+++ b/content/browser/indexed_db/leveldb/leveldb_transaction.h
@@ -30,11 +30,6 @@
// Returns true if this operation performs a change, where the value wasn't
// already deleted.
bool Remove(const base::StringPiece& key);
-
- leveldb::Status RemoveRange(const base::StringPiece& begin,
- const base::StringPiece& end,
- bool upper_open);
-
virtual leveldb::Status Get(const base::StringPiece& key,
std::string* value,
bool* found);
@@ -50,22 +45,16 @@
private:
friend class base::RefCounted<LevelDBTransaction>;
- FRIEND_TEST_ALL_PREFIXES(LevelDBTransactionTest, GetAndPut);
- FRIEND_TEST_ALL_PREFIXES(LevelDBTransactionTest, Commit);
- FRIEND_TEST_ALL_PREFIXES(LevelDBTransactionTest, Iterator);
- FRIEND_TEST_ALL_PREFIXES(LevelDBTransactionTest, RemoveRangeBackingData);
- FRIEND_TEST_ALL_PREFIXES(LevelDBTransactionTest,
- RemoveRangeBackingDataUpperOpen);
- FRIEND_TEST_ALL_PREFIXES(LevelDBTransactionTest, RemoveRangeMemoryData);
- FRIEND_TEST_ALL_PREFIXES(LevelDBTransactionTest,
- RemoveRangeMemoryDataUpperOpen);
+ FRIEND_TEST_ALL_PREFIXES(LevelDBDatabaseTest, Transaction);
+ FRIEND_TEST_ALL_PREFIXES(LevelDBDatabaseTest, TransactionCommitTest);
+ FRIEND_TEST_ALL_PREFIXES(LevelDBDatabaseTest, TransactionIterator);
struct Record {
Record();
~Record();
std::string key;
std::string value;
- bool deleted = false;
+ bool deleted;
};
class Comparator {
« no previous file with comments | « content/browser/indexed_db/indexed_db_database.cc ('k') | content/browser/indexed_db/leveldb/leveldb_transaction.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698