Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1270)

Unified Diff: remoting/protocol/connection_unittest.cc

Issue 2712693004: Disable flaky Webrtc/ConnectionTest.Audio on Linux/ChromeOS (Closed)
Patch Set: d'oh Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/connection_unittest.cc
diff --git a/remoting/protocol/connection_unittest.cc b/remoting/protocol/connection_unittest.cc
index d18c2b080c2b930570cc37dac19595469eff883d..9aecebd242db2b1aaf080ab6c806efca83c91782 100644
--- a/remoting/protocol/connection_unittest.cc
+++ b/remoting/protocol/connection_unittest.cc
@@ -622,7 +622,10 @@ TEST_P(ConnectionTest, VideoStats) {
EXPECT_LE(stats.client_stats.time_rendered, finish_time);
}
-// Disabling due to failures after WebRTC roll http://crbug.com/685910
+// Flaky on Linux/ChromeOS, crbug.com/685910.
+// Note: Apparently it's not possible to use the common MAYBE_ prefix with
+// TEST_P, so ifdef it out completely.
+#if !defined(OS_LINUX) && !defined(OS_CHROMEOS)
TEST_P(ConnectionTest, Audio) {
Connect();
@@ -633,6 +636,7 @@ TEST_P(ConnectionTest, Audio) {
client_audio_player_.WaitForSamples(kAudioSampleRate * 2);
client_audio_player_.Verify();
}
+#endif
TEST_P(ConnectionTest, FirstCaptureFailed) {
Connect();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698