content/renderer/push_messaging/push_messaging_client.h - Issue 2712693002: Implement some follow-ups after mojofiction of Push-messaging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/push_messaging/push_messaging_client.h

Issue 2712693002: Implement some follow-ups after mojofiction of Push-messaging. (Closed)

Patch Set: code rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/push_messaging/push_messaging_client.h

diff --git a/content/renderer/push_messaging/push_messaging_client.h b/content/renderer/push_messaging/push_messaging_client.h

index 430d601708eb92b70b95d1781c92bc8a9cabc77a..4cda6e433e7d5335cc979b7b4414b5885d8d2582 100644

--- a/content/renderer/push_messaging/push_messaging_client.h

+++ b/content/renderer/push_messaging/push_messaging_client.h

@@ -59,7 +59,7 @@ class PushMessagingClient : public RenderFrameObserver,

const PushSubscriptionOptions& options,

std::unique_ptr<blink::WebPushSubscriptionCallbacks> callbacks);

- void SubscribeCallback(

+ void DidSubscribe(

std::unique_ptr<blink::WebPushSubscriptionCallbacks> callbacks,

content::PushRegistrationStatus status,

const base::Optional<GURL>& endpoint,