Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: content/child/push_messaging/push_provider.h

Issue 2712693002: Implement some follow-ups after mojofiction of Push-messaging. (Closed)
Patch Set: code rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/push_messaging/push_provider.h
diff --git a/content/child/push_messaging/push_provider.h b/content/child/push_messaging/push_provider.h
index 1b9c9a7af8e01622413fde2d00f71aa4a80dc491..5f89d7ffe11ec84204af2ed672368229db43ce7f 100644
--- a/content/child/push_messaging/push_provider.h
+++ b/content/child/push_messaging/push_provider.h
@@ -67,7 +67,7 @@ class PushProvider : public blink::WebPushProvider,
static void GetInterface(mojom::PushMessagingRequest request);
- void SubscribeCallback(
+ void DidSubscribe(
std::unique_ptr<blink::WebPushSubscriptionCallbacks> callbacks,
content::PushRegistrationStatus status,
const base::Optional<GURL>& endpoint,
@@ -75,14 +75,14 @@ class PushProvider : public blink::WebPushProvider,
const base::Optional<std::vector<uint8_t>>& p256dh,
const base::Optional<std::vector<uint8_t>>& auth);
- void UnsubscribeCallback(
+ void DidUnsubscribe(
std::unique_ptr<blink::WebPushUnsubscribeCallbacks> callbacks,
bool is_success,
bool did_unsubscribe,
blink::WebPushError::ErrorType error_type,
const base::Optional<std::string>& error_message);
- void GetSubscriptionCallback(
+ void DidGetSubscription(
std::unique_ptr<blink::WebPushSubscriptionCallbacks> callbacks,
content::PushGetRegistrationStatus status,
const base::Optional<GURL>& endpoint,
@@ -90,7 +90,7 @@ class PushProvider : public blink::WebPushProvider,
const base::Optional<std::vector<uint8_t>>& p256dh,
const base::Optional<std::vector<uint8_t>>& auth);
- void GetPermissionStatusCallback(
+ void DidGetPermissionStatus(
std::unique_ptr<blink::WebPushPermissionStatusCallbacks> callbacks,
bool is_success,
blink::WebPushPermissionStatus status,
« no previous file with comments | « content/browser/push_messaging/push_messaging_manager.cc ('k') | content/child/push_messaging/push_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698