Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: chrome/browser/chromeos/app_mode/kiosk_app_manager.cc

Issue 271263002: New test cases for kiosk app crx file cache. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Improvement based on comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
diff --git a/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc b/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
index 8b38fbf40c99d096485cbf2792e8e61e5197b265..f2f906876974d5fadc27ef61b695ab61593dfd09 100644
--- a/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
+++ b/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
@@ -366,7 +366,7 @@ void KioskAppManager::RemoveObserver(KioskAppManagerObserver* observer) {
KioskAppManager::KioskAppManager() : ownership_established_(false) {
base::FilePath cache_dir;
- GetKioskAppCrxCacheDir(&cache_dir);
+ GetCrxCacheDir(&cache_dir);
external_cache_.reset(
new ExternalCache(cache_dir,
g_browser_process->system_request_context(),
@@ -530,10 +530,16 @@ void KioskAppManager::SetAutoLoginState(AutoLoginState state) {
prefs->CommitPendingWrite();
}
-void KioskAppManager::GetKioskAppCrxCacheDir(base::FilePath* cache_dir) {
+void KioskAppManager::GetCrxCacheDir(base::FilePath* cache_dir) {
base::FilePath user_data_dir;
CHECK(PathService::Get(chrome::DIR_USER_DATA, &user_data_dir));
*cache_dir = user_data_dir.AppendASCII(kCrxCacheDir);
}
+bool KioskAppManager::GetCachedCrx(const std::string& app_id,
+ base::FilePath* file_path,
+ std::string* version) {
+ return external_cache_->GetExtension(app_id, file_path, version);
+}
+
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698