New test cases for kiosk app crx file cache.

chrome/browser/extensions/updater/local_extension_cache.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/updater/local_extension_cache.h"
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/files/file_enumerator.h"
 #include "base/sequenced_task_runner.h"
@@ skipping 408 matching lines @@
 
   CacheMap::iterator it = cached_extensions_.find(id);
   if (it != cached_extensions_.end()) {
     Version new_version(info.version);
     Version prev_version(it->second.version);
     if (new_version.CompareTo(prev_version) <= 0) {
       DCHECK(0) << "Cache contains newer or the same version";
       callback.Run(info.file_path, true);
       return;
     }
+    it->second = info;
+  } else {
+    it = cached_extensions_.insert(std::make_pair(id, info)).first;
   }
-  it = cached_extensions_.insert(std::make_pair(id, info)).first;

[jennyz, 2014/05/09 20:08:08]

std::map won't insert the element if the key exists. Therefore, the version is
not updated in cached_extensions_ for the app with |id|. This bug is exposed
during KioskAppManagerTest::UpdateApp.

   // Time from file system can have lower precision so use precise "now".
   it->second.last_used = base::Time::Now();
 
   callback.Run(info.file_path, false);
 }
 
 // static
 void LocalExtensionCache::BackendRemoveCacheEntry(
     const base::FilePath& file_path) {
   base::DeleteFile(file_path, true /* recursive */);
@@ skipping 32 matching lines @@
 
 LocalExtensionCache::CacheItemInfo::CacheItemInfo(
     const std::string& version,
     const base::Time& last_used,
     uint64 size,
     const base::FilePath& file_path)
     : version(version), last_used(last_used), size(size), file_path(file_path) {
 }
 
 }  // namespace extensions