Add swarmed version of VR tests to FYI bot

testing/buildbot/chromium.fyi.json

Index: testing/buildbot/chromium.fyi.json
diff --git a/testing/buildbot/chromium.fyi.json b/testing/buildbot/chromium.fyi.json
index eddafc5a25fc49ee90fb76f9787adc1b714ba256..5a643cdcf7eb4020906463512def51251cdb5d55 100644
--- a/testing/buildbot/chromium.fyi.json
+++ b/testing/buildbot/chromium.fyi.json
@@ -222,6 +222,26 @@
   "Android VR Tests": {
     "gtest_tests": [
       {
+        "args": [
+          "--shared-prefs-file=chrome/android/shared_preference_files/test/vr_cardboard_skipdon_setupcomplete.json",

[bsheedy, 2017/02/23 01:37:01]

--shared-prefs-file is currently only used in test_runner.py if the test is an
instrumentation test. Will it need to be changed to also support gtests, or will
swarming somehow determine that the underlying APK is actually an
instrumentation test and use that?

[jbudorick, 2017/02/23 19:45:05]

This is fine. I can explain in more detail why next week if you'd like.

[bsheedy, 2017/02/23 19:48:22]

Sure - I'll be messing around with this stuff enough in the future that
understanding what's going on will be helpful.

+          "--additional-apk=third_party/gvr-android-sdk/test-apks/vr_services/vr_services_current.apk"
+        ],
+        "name": "nonddready-cardboard-current_chrome_public_test_vr_apk",
+        "override_isolate_target": "chrome_public_test_vr_apk",
+        "swarming": {
+          "can_use_on_swarming_builders": true,
+          "dimension_sets": [
+            {
+              "android_devices": "1",
+              "device_os": "NRD91N",

[bpastene, 2017/02/23 19:54:00]

Just so you're aware, you're triggering this test onto a swarming pool that's
already pretty over-subscribed:
https://chromium-swarm.appspot.com/botlist?c=id&c=os&c=task&c=status&f=device...

Expect long wait times or expired tasks as-is.

[bsheedy, 2017/02/23 20:44:40]

Thanks for the notification. Are there any other pools running N that are less
busy?

+              "device_type": "bullhead"
+            }
+          ],
+          "hard_timeout": 960
+        },
+        "test": "chrome_public_test_vr_apk"
+      },
+      {
         "swarming": {
           "can_use_on_swarming_builders": false
         },
@@ -230,6 +250,17 @@
     ],
     "instrumentation_tests": [
       {
+        "args": [
+          "--shared-prefs-file=chrome/android/shared_preference_files/test/vr_cardboard_skipdon_setupcomplete.json",
+          "--additional-apk=third_party/gvr-android-sdk/test-apks/vr_services/vr_services_current.apk"
+        ],
+        "test": "chrome_public_test_vr_apk"

[bsheedy, 2017/02/23 01:37:01]

Not sure if this will cause issues since it'll create multiple steps with the
same name (instrumentation_tests don't support the "name" field like
gtest_tests). Might have to add support for that, or would it work to just stick
this in a gtest with can_use_on_swarming_builders set to false?

[jbudorick, 2017/02/23 19:45:05]

This is an unusual setup, though I *think* it'll still work as-is. The recipe
system can handle multiple steps w/ the same name.
No, I don't think this would work.

+      },
+      {
+        "args": [
+          "--shared-prefs-file=chrome/android/shared_preference_files/test/vr_ddview_skipdon_setupcomplete.json",
+          "--additional-apk=third_party/gvr-android-sdk/test-apks/vr_services/vr_services_current.apk"
+        ],
         "test": "chrome_public_test_vr_apk"
       }
     ]