third_party/WebKit/Source/web/ContextMenuClientImpl.cpp - Issue 2712603007: Select All present even all selectable text has been selected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

Issue 2712603007: Select All present even all selectable text has been selected (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp b/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

index 52093ffa4cdba849df607b2b537de5ecf6d7afc3..caa73b9fbd3652e9b912ea91c3c6d4415f33d904 100644

--- a/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

@@ -180,8 +180,8 @@ bool ContextMenuClientImpl::showContextMenu(const ContextMenu* defaultMenu,

data.editFlags |= WebContextMenuData::CanPaste;

if (toLocalFrame(m_webView->focusedCoreFrame())->editor().canDelete())

data.editFlags |= WebContextMenuData::CanDelete;

- // We can always select all...

- data.editFlags |= WebContextMenuData::CanSelectAll;

+ if (toLocalFrame(m_webView->focusedCoreFrame())->editor().canSelectAll())

+ data.editFlags |= WebContextMenuData::CanSelectAll;

data.editFlags |= WebContextMenuData::CanTranslate;

// Links, Images, Media tags, and Image/Media-Links take preference over