third_party/WebKit/Source/core/editing/Editor.cpp - Issue 2712603007: Select All present even all selectable text has been selected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Editor.cpp

Issue 2712603007: Select All present even all selectable text has been selected (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/Editor.cpp

diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp

index 147b10fa09c203c7d4978f25893ff29ef469de4d..a58840fc67ac71f1b03a6ecd29d41f275f32a7d0 100644

--- a/third_party/WebKit/Source/core/editing/Editor.cpp

+++ b/third_party/WebKit/Source/core/editing/Editor.cpp

@@ -331,6 +331,10 @@ bool Editor::canDelete() const {

selection.computeVisibleSelectionInDOMTree().rootEditableElement();

}

+bool Editor::canSelectAll() const {

+ return frame().selection().canSelectAll();

bool Editor::smartInsertDeleteEnabled() const {

if (Settings* settings = frame().settings())

return settings->getSmartInsertDeleteEnabled();