components/supervised_user_error_page/supervised_user_error_page_unittest.cc - Issue 2712513004: Use a qualified path for grit-generated headers in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/supervised_user_error_page/supervised_user_error_page_unittest.cc

Issue 2712513004: Use a qualified path for grit-generated headers in components/ (Closed)

Patch Set: res Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/security_interstitials/DEPS ('K') | « components/supervised_user_error_page/supervised_user_error_page_android.cc ('k') | components/translate/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/supervised_user_error_page/supervised_user_error_page_unittest.cc

diff --git a/components/supervised_user_error_page/supervised_user_error_page_unittest.cc b/components/supervised_user_error_page/supervised_user_error_page_unittest.cc

index 4baf4cc6da5b4d8156cdc50d74a9caf08de403ed..1c48ed6eba5adecf1316a0d80809256ff97f14e1 100644

--- a/components/supervised_user_error_page/supervised_user_error_page_unittest.cc

+++ b/components/supervised_user_error_page/supervised_user_error_page_unittest.cc

@@ -2,10 +2,10 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include "base/strings/utf_string_conversions.h"

#include "components/supervised_user_error_page/supervised_user_error_page.h"

-#include "grit/components_resources.h"

-#include "grit/components_strings.h"

+#include "base/strings/utf_string_conversions.h"

sdefresne 2017/02/23 11:34:53 nit: can you add a blank line here?

Nico 2017/02/23 16:57:53 Done.

+#include "components/grit/components_resources.h"

+#include "components/strings/grit/components_strings.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest-param-test.h"

#include "testing/gtest/include/gtest/gtest.h"