Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Side by Side Diff: components/resources/BUILD.gn

Issue 2712513004: Use a qualified path for grit-generated headers in components/ (Closed)
Patch Set: more checkdeps Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//printing/features/features.gni") 5 import("//printing/features/features.gni")
6 import("//tools/grit/grit_rule.gni") 6 import("//tools/grit/grit_rule.gni")
7 import("//third_party/brotli/brotli.gni") 7 import("//third_party/brotli/brotli.gni")
8 8
9 about_credits_file = "$target_gen_dir/about_credits.html" 9 about_credits_file = "$target_gen_dir/about_credits.html"
10 about_credits_file_bro = "$target_gen_dir/about_credits.bro" 10 about_credits_file_bro = "$target_gen_dir/about_credits.bro"
11 11
12 group("resources") { 12 group("resources") {
13 public_deps = [ 13 public_deps = [
14 ":components_resources", 14 ":components_resources",
15 ":components_scaled_resources", 15 ":components_scaled_resources",
16 ] 16 ]
17 } 17 }
18 18
19 grit("components_resources") { 19 grit("components_resources") {
20 source = "components_resources.grd" 20 source = "components_resources.grd"
21 use_qualified_include = true
21 22
22 # TODO(hashimoto): Remove this line. 23 # TODO(hashimoto): Remove this line.
23 output_name = "components_resources_new" 24 output_name = "components_resources_new"
24 outputs = [ 25 outputs = [
25 "grit/components_resources.h", 26 "grit/components_resources.h",
26 "components_resources.pak", 27 "components_resources.pak",
27 ] 28 ]
28 output_dir = "$root_gen_dir/components" 29 output_dir = "$root_gen_dir/components"
29 30
30 grit_flags = [ 31 grit_flags = [
31 "-E", 32 "-E",
32 "about_credits_file=" + rebase_path(about_credits_file_bro, root_build_dir), 33 "about_credits_file=" + rebase_path(about_credits_file_bro, root_build_dir),
33 ] 34 ]
34 defines = [ "enable_print_preview=$enable_print_preview" ] 35 defines = [ "enable_print_preview=$enable_print_preview" ]
35 36
36 deps = [ 37 deps = [
37 ":compressed_about_credits", 38 ":compressed_about_credits",
38 ] 39 ]
39 } 40 }
40 41
41 grit("components_scaled_resources") { 42 grit("components_scaled_resources") {
42 source = "components_scaled_resources.grd" 43 source = "components_scaled_resources.grd"
43 44
45 # TODO(thakis): Enable this, https://crbug.com/401588
46 #use_qualified_include = true
47
44 # TODO(hashimoto): Remove this line. 48 # TODO(hashimoto): Remove this line.
45 output_name = "components_scaled_resources_new" 49 output_name = "components_scaled_resources_new"
46 outputs = [ 50 outputs = [
47 "grit/components_scaled_resources.h", 51 "grit/components_scaled_resources.h",
48 "grit/components_scaled_resources_map.cc", 52 "grit/components_scaled_resources_map.cc",
49 "grit/components_scaled_resources_map.h", 53 "grit/components_scaled_resources_map.h",
50 "components_resources_100_percent.pak", 54 "components_resources_100_percent.pak",
51 "components_resources_200_percent.pak", 55 "components_resources_200_percent.pak",
52 "components_resources_300_percent.pak", 56 "components_resources_300_percent.pak",
53 ] 57 ]
(...skipping 22 matching lines...) Expand all
76 ] 80 ]
77 81
78 args = [ 82 args = [
79 "--target-os=$target_os", 83 "--target-os=$target_os",
80 "--depfile", 84 "--depfile",
81 rebase_path(depfile, root_build_dir), 85 rebase_path(depfile, root_build_dir),
82 "credits", 86 "credits",
83 rebase_path(about_credits_file, root_build_dir), 87 rebase_path(about_credits_file, root_build_dir),
84 ] 88 ]
85 } 89 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698