components/dom_distiller/core/dom_distiller_request_view_base_unittest.cc - Issue 2712513004: Use a qualified path for grit-generated headers in components/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/dom_distiller/core/dom_distiller_request_view_base_unittest.cc

Issue 2712513004: Use a qualified path for grit-generated headers in components/ (Closed)

Patch Set: more checkdeps Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/crash/core/browser/DEPS ('K') | « components/dom_distiller/core/dom_distiller_request_view_base.cc ('k') | components/dom_distiller/core/url_utils.cc » ('j') | components/error_page/renderer/DEPS » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include <vector>	5 #include <vector>

6	6

7 #include "components/dom_distiller/core/article_distillation_update.h"	7 #include "components/dom_distiller/core/article_distillation_update.h"

8 #include "components/dom_distiller/core/test_request_view_handle.h"	8 #include "components/dom_distiller/core/test_request_view_handle.h"

	9 #include "components/grit/components_resources.h"

	10 #include "components/strings/grit/components_strings.h"

9 #include "components/sync_preferences/testing_pref_service_syncable.h"	11 #include "components/sync_preferences/testing_pref_service_syncable.h"

10 #include "grit/components_resources.h"

11 #include "grit/components_strings.h"

12 #include "testing/gmock/include/gmock/gmock.h"	12 #include "testing/gmock/include/gmock/gmock.h"

13 #include "testing/gtest/include/gtest/gtest.h"	13 #include "testing/gtest/include/gtest/gtest.h"

14 #include "ui/base/l10n/l10n_util.h"	14 #include "ui/base/l10n/l10n_util.h"

15	15

16 using testing::HasSubstr;	16 using testing::HasSubstr;

17 using testing::Not;	17 using testing::Not;

18	18

19 namespace dom_distiller {	19 namespace dom_distiller {

20	20

21 class DomDistillerRequestViewTest : public testing::Test {	21 class DomDistillerRequestViewTest : public testing::Test {

(...skipping 197 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
219	219

220 std::unique_ptr<ArticleDistillationUpdate> article_update(	220 std::unique_ptr<ArticleDistillationUpdate> article_update(

221 new ArticleDistillationUpdate(pages, true, false));	221 new ArticleDistillationUpdate(pages, true, false));

222	222

223 handle.OnArticleUpdated(*article_update.get());	223 handle.OnArticleUpdated(*article_update.get());

224	224

225 EXPECT_THAT(handle.GetJavaScriptBuffer(), HasSubstr(show_loader));	225 EXPECT_THAT(handle.GetJavaScriptBuffer(), HasSubstr(show_loader));

226 }	226 }

227	227

228 } // namespace dom_distiller	228 } // namespace dom_distiller

OLD	NEW