components/translate/core/browser/options_menu_model.cc - Issue 2712513004: Use a qualified path for grit-generated headers in components/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/translate/core/browser/options_menu_model.cc

Issue 2712513004: Use a qualified path for grit-generated headers in components/ (Closed)

Patch Set: res Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/supervised_user_error_page/supervised_user_error_page_unittest.cc ('K') | « components/translate/DEPS ('k') | components/translate/core/browser/translate_infobar_delegate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/translate/core/browser/options_menu_model.h"	5 #include "components/translate/core/browser/options_menu_model.h"

6	6

7 #include "base/metrics/histogram.h"	7 #include "base/metrics/histogram.h"

8 #include "build/build_config.h"	8 #include "build/build_config.h"

	9 #include "components/strings/grit/components_strings.h"

9 #include "components/translate/core/browser/translate_driver.h"	10 #include "components/translate/core/browser/translate_driver.h"

10 #include "components/translate/core/browser/translate_infobar_delegate.h"	11 #include "components/translate/core/browser/translate_infobar_delegate.h"

11 #include "grit/components_strings.h"

12 #include "ui/base/l10n/l10n_util.h"	12 #include "ui/base/l10n/l10n_util.h"

13	13

14 namespace translate {	14 namespace translate {

15	15

16 namespace {	16 namespace {

17	17

18 const char kAboutGoogleTranslateURL[] =	18 const char kAboutGoogleTranslateURL[] =

19 #if defined(OS_CHROMEOS)	19 #if defined(OS_CHROMEOS)

20 "https://support.google.com/chromebook/?p=ib_translation_bar";	20 "https://support.google.com/chromebook/?p=ib_translation_bar";

21 #else	21 #else

(...skipping 104 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
126 break;	126 break;

127 }	127 }

128	128

129 default:	129 default:

130 NOTREACHED() << "Invalid command id from menu.";	130 NOTREACHED() << "Invalid command id from menu.";

131 break;	131 break;

132 }	132 }

133 }	133 }

134	134

135 } // namespace translate	135 } // namespace translate

OLD	NEW