third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js - Issue 2712513002: DevTools: extract ObjectUI module from Components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

Issue 2712513002: DevTools: extract ObjectUI module from Components (Closed)

Patch Set: fix build.gn Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

index fed096b7a6e8d1fc123fefee008fcf0509b9c2e8..fc641116b23d2e85ccb7e318ad4b1cf4f099fb06 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

@@ -30,7 +30,7 @@

Sources.ScopeChainSidebarPane = class extends UI.VBox {

constructor() {

super();

- this._expandController = new Components.ObjectPropertiesSectionExpandController();

+ this._expandController = new ObjectUI.ObjectPropertiesSectionExpandController();

this._linkifier = new Components.Linkifier();

this._update();

}

@@ -113,7 +113,7 @@ Sources.ScopeChainSidebarPane = class extends UI.VBox {

titleElement.createChild('div', 'scope-chain-sidebar-pane-section-subtitle').textContent = subtitle;

titleElement.createChild('div', 'scope-chain-sidebar-pane-section-title').textContent = title;

- var section = new Components.ObjectPropertiesSection(

+ var section = new ObjectUI.ObjectPropertiesSection(

Sources.SourceMapNamesResolver.resolveScopeInObject(scope), titleElement, this._linkifier, emptyPlaceholder,

true, extraProperties);

this._expandController.watchSection(title + (subtitle ? ':' + subtitle : ''), section);