Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7163)

Unified Diff: chrome/test/data/webui/settings/settings_autofill_section_browsertest.js

Issue 2712473002: Fix cause of flakiness and enable CreditCardTests. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
diff --git a/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js b/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
index 360debcda41d7b6f8f37bb6f0c6a6964cd609efc..30e8e862acf8b882ec873e7bf65fc4ed039827d8 100644
--- a/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
+++ b/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
@@ -170,10 +170,7 @@ SettingsAutofillSectionBrowserTest.prototype = {
},
};
-// Disabled because of flakiness http://crbug.com/694289
-TEST_F('SettingsAutofillSectionBrowserTest',
- 'DISABLED_CreditCardTests',
- function() {
+TEST_F('SettingsAutofillSectionBrowserTest', 'CreditCardTests', function() {
var self = this;
setup(function() {
@@ -264,6 +261,12 @@ TEST_F('SettingsAutofillSectionBrowserTest',
assertNotEquals(oldCreditCardDialog.title_, newCreditCardDialog.title_);
assertNotEquals('', newCreditCardDialog.title_);
assertNotEquals('', oldCreditCardDialog.title_);
+
+ // Wait for dialogs to open before finishing test.
+ return Promise.all([
+ test_util.whenAttributeIs(newCreditCardDialog.$.dialog, 'open', true),
+ test_util.whenAttributeIs(oldCreditCardDialog.$.dialog, 'open', true),
+ ]);
});
test('verifyExpiredCreditCardYear', function() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698