ozone: Reject overlays when a test buffer can't be allocated.

ui/ozone/platform/drm/gpu/drm_overlay_validator.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/ozone/platform/drm/gpu/drm_overlay_validator.h"
 
 #include <drm_fourcc.h>
 
 #include "ui/gfx/geometry/size_conversions.h"
 #include "ui/ozone/platform/drm/common/drm_util.h"
@@ skipping 27 matching lines @@
   // Check if we can re-use existing buffers.
   for (const auto& buffer : *reusable_buffers) {
     if (buffer->GetFramebufferPixelFormat() == format &&
         buffer->GetSize() == size) {
       return buffer;
     }
   }
 
   scoped_refptr<ScanoutBuffer> scanout_buffer =
       buffer_generator->Create(drm_device, format, size);
-  reusable_buffers->push_back(scanout_buffer);
+  if (scanout_buffer)
+    reusable_buffers->push_back(scanout_buffer);
 
   return scanout_buffer;
 }
 
 gfx::Size GetScaledSize(const gfx::Size original_size,
                         const gfx::Rect display_rect,
                         const gfx::RectF crop_rect) {
   if (!crop_rect.IsEmpty()) {
     return gfx::ToCeiledSize(
         gfx::SizeF(display_rect.width() / crop_rect.width(),
@@ skipping 66 matching lines @@
 
   for (auto& overlay : validated_params) {
     if (!overlay.is_overlay_candidate)
       continue;
 
     gfx::Size scaled_buffer_size = GetScaledSize(
         overlay.buffer_size, overlay.display_rect, overlay.crop_rect);
 
     uint32_t original_format = GetFourCCFormatForFramebuffer(overlay.format);
     scoped_refptr<ScanoutBuffer> buffer =
-        GetBufferForPageFlipTest(drm, scaled_buffer_size, original_format,
+        GetBufferForPageFlipTest(drm, overlay.buffer_size, original_format,
                                  buffer_generator_, &reusable_buffers);
-    DCHECK(buffer);
 
     OverlayPlane plane(buffer, overlay.plane_z_order, overlay.transform,
                        overlay.display_rect, overlay.crop_rect);
     test_list.push_back(plane);
 
-    if (controller->TestPageFlip(test_list)) {
+    if (buffer && controller->TestPageFlip(test_list)) {
       overlay.is_overlay_candidate = true;
 
       // If size scaling is needed, find an optimal format.
       if (overlay.plane_z_order && scaled_buffer_size != overlay.buffer_size) {
         uint32_t optimal_format = FindOptimalBufferFormat(
             original_format, overlay.plane_z_order, overlay.display_rect,
             window_->bounds(), controller);
 
         if (original_format != optimal_format) {
           OverlayPlane original_plain = test_list.back();
@@ skipping 19 matching lines @@
           }
         }
       }
     } else {
       // If test failed here, platform cannot support this configuration
       // with current combination of layers. This is usually the case when this
       // plane has requested post processing capability which needs additional
       // hardware resources and they might be already in use by other planes.
       // For example this plane has requested scaling capabilities and all
       // available scalars are already in use by other planes.
-      DCHECK(test_list.size() > 1);
       overlay.is_overlay_candidate = false;
       test_list.pop_back();
     }
   }
 
   UpdateOverlayHintsCache(test_list);
 
   return validated_params;
 }
 
@@ skipping 68 matching lines @@
 
     // Make sure we dont hold reference to buffer when caching this plane list.
     plane.buffer = nullptr;
   }
 
   DCHECK(hints_plane_list.size() == overlay_hints.size());
   overlay_hints_cache_.Put(hints_plane_list, overlay_hints);
 }
 
 }  // namespace ui