Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2154)

Unified Diff: build/android/gyp/javac.py

Issue 2712453003: Fix up javac.py's depfile to include all relevant inputs (Closed)
Patch Set: don't need to add processors Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/javac.py
diff --git a/build/android/gyp/javac.py b/build/android/gyp/javac.py
index df5325f7f058d5c7915fef1acdc7ed057d855f26..0eacb3c4a60cf7ce01291fe9e3d2608d72ffa544 100755
--- a/build/android/gyp/javac.py
+++ b/build/android/gyp/javac.py
@@ -420,9 +420,12 @@ def main(argv):
java_files = _FilterJavaFiles(java_files, options.javac_includes)
- javac_cmd = ['javac']
if options.use_errorprone_path:
- javac_cmd = [options.use_errorprone_path] + ERRORPRONE_OPTIONS
+ javac_path = options.use_errorprone_path
+ javac_cmd = [javac_path] + ERRORPRONE_OPTIONS
+ else:
+ javac_path = distutils.spawn.find_executable('javac')
+ javac_cmd = [javac_path]
javac_cmd.extend((
'-g',
@@ -473,8 +476,10 @@ def main(argv):
else:
classpath_inputs.append(path)
- # Compute the list of paths that when changed, we need to rebuild.
- input_paths = classpath_inputs + options.java_srcjars + java_files
+ # GN already knows of java_files, so listing them just make things worse when
+ # they change.
+ depfile_deps = [javac_path] + classpath_inputs + options.java_srcjars
+ input_paths = depfile_deps + java_files
output_paths = [
options.jar_path,
@@ -493,6 +498,7 @@ def main(argv):
lambda changes: _OnStaleMd5(changes, options, javac_cmd, java_files,
classpath_inputs),
options,
+ depfile_deps=depfile_deps,
input_paths=input_paths,
input_strings=javac_cmd,
output_paths=output_paths,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698