Issue 271243004: content: Do the generation of webkit_version.h directly in content_common.gypi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 271243004: content: Do the generation of webkit_version.h directly in content_common.gypi (Closed)

Created:
6 years, 7 months ago by tfarina

Modified:
6 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews, Avi (use Gerrit), jochen (gone - plz use gerrit), darin (slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

content: Do the generation of webkit_version.h directly in content_common.gypi Looks cleaner this way and avoids creating an unnecessary target in a random place in content.gyp, also helps keeping things self-contained. R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270859

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -39 lines)			Patch
	M	content/content.gyp	View		1 chunk	+0 lines, -38 lines	0 comments	Download
	M	content/content_common.gypi	View		1 chunk	+24 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/271243004/1

6 years, 7 months ago (2014-05-15 22:34:24 UTC) #4

Message was sent while issue was closed.

Change committed as 270859