Issue 2712383004: Revert "Record shebangs as comments."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2712383004: Revert "Record shebangs as comments." (Closed)

Created:
3 years, 9 months ago by ahe

Modified:
3 years, 9 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Revert "Record shebangs as comments." This reverts commit c4045d4ce8f7c72545975e188076bee76be769da. Committed: https://github.com/dart-lang/sdk/commit/9a84b63402ae5d7985de533c2192f39d20abd66b

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -4 lines)			Patch
	M	pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart	View		2 chunks	+14 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ahe

TBR I broke dart2js: tests/co19/src/Language/Libraries_and_Scripts/definition_syntax_t12_lib.dart:1:1: Error: Can't have modifier '#' here. Try replacing modifier '#' ...

3 years, 9 months ago (2017-02-27 15:34:13 UTC) #2

ahe

Committed patchset #1 (id:1) manually as 9a84b63402ae5d7985de533c2192f39d20abd66b (presubmit successful).

3 years, 9 months ago (2017-02-27 15:34:43 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages