Issue 27123002: Move Region.cpp/.h to platform/

Issue 27123002: Move Region.cpp/.h to platform/ (Closed)

Created:
7 years, 2 months ago by pilgrim_google

Modified:
7 years, 2 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, kenneth.christiansen, jamesr, danakj, dsinclair, blink-layers+watch_chromium.org, Rik, Stephen Chennney, pdr., darin (slow to review)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move Region.cpp/.h to platform/ BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159541

Patch Set 2 : rebase, address feedback #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -1235 lines)			Patch
M	Source/core/core.gypi	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/page/Page.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/page/scrolling/ScrollingCoordinator.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
D	Source/core/platform/graphics/Region.h	View		1 chunk	+0 lines, -180 lines	0 comments	Download
D	Source/core/platform/graphics/Region.cpp	View		1 chunk	+0 lines, -611 lines	0 comments	Download
M	Source/platform/blink_platform.gypi	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
A +	Source/platform/geometry/Region.h	View	1	2 chunks	+6 lines, -5 lines	0 comments	Download
A +	Source/platform/geometry/Region.cpp	View	1	16 chunks	+39 lines, -40 lines	0 comments	Download
A +	Source/platform/geometry/RegionTest.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/tests/RegionTest.cpp	View	1	1 chunk	+0 lines, -394 lines	0 comments	Download
M	Source/web/web.gypi	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

LGTM with the files moved to a slightly different place. https://codereview.chromium.org/27123002/diff/1/Source/platform/blink_platform.gypi File Source/platform/blink_platform.gypi (right): https://codereview.chromium.org/27123002/diff/1/Source/platform/blink_platform.gypi#newcode209 ...

7 years, 2 months ago (2013-10-13 15:19:51 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/27123002/7001

7 years, 2 months ago (2013-10-13 15:50:02 UTC) #3

Message was sent while issue was closed.

Thanks!

Expand Messages | Collapse Messages