Remove non-MD code from ShelfButton

ash/test/shelf_view_test_api.cc

Index: ash/test/shelf_view_test_api.cc
diff --git a/ash/test/shelf_view_test_api.cc b/ash/test/shelf_view_test_api.cc
index 92afe5db3bb10c3486847aaa680032aa9bb38dae..b1c7655bf774e68f2e08e21bcfbe6f4fdada00b5 100644
--- a/ash/test/shelf_view_test_api.cc
+++ b/ash/test/shelf_view_test_api.cc
@@ -136,11 +136,11 @@ gfx::Size ShelfViewTestAPI::GetPreferredSize() {
 }
 
 int ShelfViewTestAPI::GetButtonSize() {

[James Cook, 2017/02/28 20:35:11]

nit: Since this and GetButtonSpacing() just return constants, can you remove
these methods entirely and inline the constants in the tests that use them?

[mohsen, 2017/02/28 21:05:16]

Sure, I didn't remove these methods because GetMinimumDragDistance() is also
returning a constant and I wanted to be consistent. However, that one is
returning a private constant, so it makes sense to have an accessor in test api.
These ones are public constants. Done.

-  return GetShelfConstant(SHELF_BUTTON_SIZE);
+  return kShelfButtonSize;
 }
 
 int ShelfViewTestAPI::GetButtonSpacing() {
-  return GetShelfConstant(SHELF_BUTTON_SPACING);
+  return kShelfButtonSpacing;
 }
 
 int ShelfViewTestAPI::GetMinimumDragDistance() const {